add update&replace api #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #131 +/- ##
==========================================
+ Coverage 40.56% 42.10% +1.54%
==========================================
Files 22 22
Lines 2894 2978 +84
==========================================
+ Hits 1174 1254 +80
- Misses 1720 1724 +4 ☔ View full report in Codecov by Sentry. |
|
另外没啥没看到测试，pr介绍也没有。 |
qicosmos
approved these changes
Dec 14, 2023
include/mysql.hpp
Outdated
| if (condition && type == OptType::update) { | ||
| iguana::for_each(t, [&t, ¶m_binds, this](auto item, auto i) { | ||
| if (is_conflict_key<T>( | ||
| "`" + std::string(iguana::get_name<T>(i).data()) + "`")) { |
|
|
||
| template <typename T, typename... Args> | ||
| int insert_impl(OptType type, const std::vector<T> &v, bool get_insert_id, | ||
| Args &&...args) { |
| @@ -463,9 +486,38 @@ class sqlite { | |||
| } | |||
|
|
|||
| template <typename T, typename... Args> | |||
| int insert_impl(bool update, const T &t, bool get_insert_id = false, | |||
| int insert_impl(OptType type, const T &t, bool get_insert_id, | |||
| Args &&...args) { | |||
| } | ||
|
|
||
| template <typename T, typename... Args> | ||
| int insert_impl(OptType type, const std::vector<T> &v, bool get_insert_id, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.